Skip to content

Factor CLI argument processing for flags that are common across commands #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmaglie opened this issue Oct 13, 2021 · 0 comments · Fixed by #1542
Closed

Factor CLI argument processing for flags that are common across commands #1508

cmaglie opened this issue Oct 13, 2021 · 0 comments · Fixed by #1542
Assignees
@umbynos
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@cmaglie
Copy link
Member

cmaglie commented Oct 13, 2021

We could use an approach similar to the --port/-p, --protocol/-l flags: https://github.com/arduino/arduino-cli/blob/master/cli/arguments/port.go

Flags that comes to mind:

  • sketch path argument
  • --fqbn/-b (sometimes is determined from sketch.json inside sketch path)
@cmaglie cmaglie added the type: enhancement Proposed improvement label Oct 13, 2021
@cmaglie cmaglie self-assigned this Oct 13, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 13, 2021
@umbynos umbynos assigned umbynos and unassigned cmaglie Oct 22, 2021
@umbynos umbynos mentioned this issue Nov 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[breaking] uniform cli commands and flag arduino/arduino-cli
3 participants
@cmaglie @per1234 @umbynos