Skip to content

Investigate possible concurrency issue in gRPC daemon during Init #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
cmaglie opened this issue Jul 12, 2022 · 1 comment · Fixed by #1828
Closed
3 tasks done

Investigate possible concurrency issue in gRPC daemon during Init #1801

cmaglie opened this issue Jul 12, 2022 · 1 comment · Fixed by #1828
Assignees
@cmaglie
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project

Comments

@cmaglie
Copy link
Member

cmaglie commented Jul 12, 2022

Describe the problem

Following this report:

arduino/arduino-ide#681 (comment)

it seems possible to have concurrent reads and writes in the arduino-cli core instances, in particular when the Init call is ongoing and another concurrent call happens (in the example above a BoardSearch has been executed together with the Init).

To reproduce

I didn't try to reproduce it yet, but I think this is a signal of a potential problem that must be solved.

Expected behavior

The CLI must not crash

Arduino CLI version

nightly

Operating system

N/A

Operating system version

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the nightly build
  • My report contains all necessary details
@cmaglie cmaglie added the type: imperfection Perceived defect in any part of project label Jul 12, 2022
@cmaglie cmaglie self-assigned this Jul 12, 2022
@per1234 per1234 added topic: gRPC Related to the gRPC interface topic: code Related to content of the project itself labels Jul 12, 2022
@cmaglie cmaglie mentioned this issue Jul 15, 2022
Merged
5 tasks
@cmaglie cmaglie linked a pull request Aug 9, 2022 that will close this issue
[breaking] daemon: Fix concurrency and streamline access to PackageManager #1828
Merged
5 tasks
@cmaglie
Copy link
Member Author

cmaglie commented Aug 30, 2022

Fixed with #1804 and #1828

@cmaglie cmaglie closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[breaking] daemon: Fix concurrency and streamline access to PackageManager cmaglie/arduino-cli
2 participants
@cmaglie @per1234