Skip to content

[api]: Please use the same property name for the query term in the platform, board, and library search requests #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
dankeboy36 opened this issue Jan 4, 2023 · 0 comments · Fixed by #2214
Assignees
Labels
type: enhancement Proposed improvement

Comments

@dankeboy36
Copy link
Contributor

Describe the request

I want to reuse client code when searching for platforms, boards, and libraries via the gRPC API. Currently, the following search requests use different properties for the query term. The current difference is a mistake, right? Please use the same to help simplify client code. Thanks!

Describe the current behavior

Please read the request description. With JS/TS' structural typing, it would be super easy for clients to use the same JSON object for the search request.

Arduino CLI version

0.29.0

Operating system

macOS

Operating system version

11.6.5

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
@dankeboy36 dankeboy36 added the type: enhancement Proposed improvement label Jan 4, 2023
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Jun 9, 2023
@cmaglie cmaglie assigned cmaglie and MatteoPologruto and unassigned cmaglie Jun 9, 2023
@MatteoPologruto MatteoPologruto linked a pull request Jun 14, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants