-
-
Notifications
You must be signed in to change notification settings - Fork 402
Add YAML to feedback formats #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe could be useful to have also the completion for yaml? Line 119 in 9b6f769
|
the goal of this pr was just to improve the feedback package, without actually enable YAML support in If you'd like arduino-cli to support yaml format I can make the necessary changes, just let me know 😄 |
Please do. 😄 |
b53ea60
to
42b7345
Compare
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, good job! 👍
Feel free to merge as soon all checks pass.
The links check workflow is failing cause gnu.org seems down, ignore it.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)This pr enhances the
feedback
package by allowing to use also the YAML format.For the YAML marshal It's been selected a YAML dependency already present in
go.mod
titled accordingly?
See how to contribute