Monitor gRPC call now sends a 'success' message to notify open port
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
topic: code
cmaglie
force-pushed
the
success_monitor_open
branch
from
47e3fa0
to
5fe3430
Compare
davegarthsimpson
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
The
MonitorgRPC call now sends a "success" message back to the callerWhat is the current behavior?
After calling the
Monitormethod, if successful, the stream may just stay silent if no traffic is going through the port.What is the new behavior?
After calling the
Monitormethod, if successful, feedback is always sent, even if there is no traffic.Does this PR introduce a breaking change, and is titled accordingly?
No