Some refactorings on library resolution code #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
per1234
reviewed
Jul 1, 2022
There was a problem hiding this comment.
There are several breaking changes to the exported Go package API. Are those still supposed to be documented for the legacy packages?
|
The |
per1234
approved these changes
Jul 4, 2022
cmaglie
force-pushed
the
libs_refactor
branch
from
979a13e to
872d8c2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
==========================================
- Coverage 62.86% 62.80% -0.06%
==========================================
Files 218 217 -1
Lines 19462 19454 -8
==========================================
- Hits 12235 12219 -16
- Misses 6145 6150 +5
- Partials 1082 1085 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This was referenced Jun 6, 2023
There was no need to have it encapsulated in a Command
Removed dependency from types.Context
Instead of skipping include detection later, avoid to add the sources in the queue right from the beginning.
Also remove the reference to the original Library object because it's no more needed.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Just some equivalent code change to simplify and make the code more readable.
What is the current/new behavior?
no changes in behavior
Does this PR introduce a breaking change, and is titled accordingly?
No