Fix bogus "wrong file size" error in some rare cases #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aded file This will help identify the problem: - if the file is corrupted - if the package_index is wrong - if there is a bug in the CLI (more rare... but actually possible :-)
The installed packages keeps an extract of the original package_index.json, at the moment of the installation, inside a file named installed.json. This extract may turn out useful if the original package_XXX_index.json is lost or removed to keep the platform functional. On the other hand, if the original package_XXX_index.json is modified the information kept in the installed.json may be outdated and should be replaced by the upstream index: this is the reason why it's loaded after the hardware platforms.
cmaglie
added
type: imperfection
umbynos
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Package indexes are loaded after the installed platforms.
The reason for this change is that the installed packages keep an extract of the original
package_XXX_index.json, at the moment of the installation, inside a file namedinstalled.json. This extract turns out useful if the originalpackage_XXX_index.jsonis lost or removed to keep the platform functional.On the other hand, if the original
package_XXX_index.jsonis modified the information kept in theinstalled.jsonmay be outdated and should be replaced by the upstream index: this is the reason why it's loaded after the hardware platforms.What is the current behavior?
In some rare cases, the tool installation may fail due to an inconsistency in checksums and file size stored in the index and in the
installed.json.What is the new behavior?
The checksums and file size in the index will always take precedence.
Does this PR introduce a breaking change, and is titled accordingly?
No