Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile regression #1867

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 6, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Fix a weird compile regression.
  • What is the current behavior?
    The runtime.tools.PACKAGER-TOOL-VERSION.* variables are not populated (unless they are specified as a platform dependcy in the package_xxx_index.json and that index file is present).
  • What is the new behavior?
    The above bug is fixed.

@cmaglie cmaglie self-assigned this Sep 6, 2022
@cmaglie cmaglie added priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project criticality: highest Of highest impact labels Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1867 (ca7730f) into master (14c8500) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
+ Coverage   36.62%   36.67%   +0.04%     
==========================================
  Files         231      231              
  Lines       19610    19609       -1     
==========================================
+ Hits         7182     7191       +9     
+ Misses      11600    11593       -7     
+ Partials      828      825       -3     
Flag Coverage Δ
unit 36.67% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
legacy/builder/hardware_loader.go 88.88% <100.00%> (-0.40%) ⬇️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️
arduino/cores/packagemanager/loader.go 74.30% <0.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cmaglie cmaglie merged commit 3cd782d into arduino:master Sep 6, 2022
@cmaglie cmaglie deleted the fix_compile_regression branch September 6, 2022 15:49
cmaglie added a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: highest Of highest impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants