Do not treat custom menu options without label as 'malformed' #1882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Do not report the board menu without a label as an error. It happens when the
boards.txt
does not specify a top-levelmenu.xxx
directive, for example:If the menu directive is missing the CLI fails to load the whole platform with the message:
The CLI will silently accept the board option without the label.
Not exactly a breaking change, but worth noting that the gRPC response to
BoardDetails
now may have aConfigOption
with a blankoption_label
field: