chore: update to golang 1.19 #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.45% // Head: 36.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
- Coverage 36.45% 36.43% -0.02%
==========================================
Files 228 228
Lines 19316 19316
==========================================
- Hits 7041 7038 -3
- Misses 11442 11444 +2
- Partials 833 834 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Bikappa
commented
Jan 4, 2023
Bikappa
force-pushed
the
chore/go-1.19
branch
4 times, most recently
from
28edac6 to
94256b7
Compare
cmaglie
reviewed
Jan 5, 2023
cmaglie
approved these changes
Jan 5, 2023
cmaglie
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
It updates the golang language version used in the source files. The version is bumped from go 1.17 to go 1.19.
The change will provide the latest security patches and bug fixes in the standard library and it will allow developers to write code with modern syntax.
In this regard the main language feature brought in are generics, that enable writing of simpler and more concise interfaces in addition to the possibility to use such interfaces from third party modules.
See golang release notes for more details.
It also update
go.sumfiles after runninggo mod tidyWhat is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Not on the interface behaviours, but it's worth mentioning that go 1.19 is now required for compilation.
Other information