Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Sync check-markdown-task with upstream version of the workflow #2118

Merged

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

check-markdown-task workflow has been updated to match its upstream template.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

markdown-link-check tool version has been pinned to 3.10.3 because the latest release of the tool introduced some errors. More on the subject here: tcort/markdown-link-check#246

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Mar 21, 2023
@MatteoPologruto MatteoPologruto self-assigned this Mar 21, 2023
@MatteoPologruto MatteoPologruto changed the title [skip-changelog] Sync check-markdown-task with upstream version [skip-changelog] Sync check-markdown-task with upstream version of the workflow Mar 21, 2023
@MatteoPologruto MatteoPologruto marked this pull request as ready for review March 21, 2023 15:07
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (a8b52ea) 34.95% compared to head (3776893) 35.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   34.95%   35.04%   +0.08%     
==========================================
  Files         232      232              
  Lines       20570    20570              
==========================================
+ Hits         7190     7208      +18     
+ Misses      12531    12518      -13     
+ Partials      849      844       -5     
Flag Coverage Δ
unit 35.04% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo!

@MatteoPologruto MatteoPologruto merged commit 5f03cb9 into arduino:master Mar 22, 2023
@MatteoPologruto MatteoPologruto deleted the fix-check-markdown-links branch March 22, 2023 08:14
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants