Skip to content

[skip-changelog] Fix failing board tests #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2023
Merged

[skip-changelog] Fix failing board tests #2222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed6b360
Fix failing board tests after package index updates
MatteoPologruto Jun 21, 2023
2586641
Remove duplicate test
MatteoPologruto Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions internal/integrationtest/board/board_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,30 +124,6 @@ func TestBoardListWithFqbnFilterInvalid(t *testing.T) {
requirejson.Query(t, stderr, ".error", `"Invalid FQBN: not an FQBN: yadayada"`)
}

func TestBoardListWithInvalidDiscovery(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

_, _, err := cli.Run("core", "update-index")
require.NoError(t, err)
_, _, err = cli.Run("board", "list")
require.NoError(t, err)

// check that the CLI does not crash if an invalid discovery is installed
// (for example if the installation fails midway).
// https://github.com/arduino/arduino-cli/issues/1669
toolDir := cli.DataDir().Join("packages", "builtin", "tools", "serial-discovery")
dirsToEmpty, err := toolDir.ReadDir()
require.NoError(t, err)
require.Len(t, dirsToEmpty, 1)
require.NoError(t, dirsToEmpty[0].RemoveAll())
require.NoError(t, dirsToEmpty[0].MkdirAll())

_, stderr, err := cli.Run("board", "list")
require.NoError(t, err)
require.Contains(t, string(stderr), "builtin:serial-discovery")
}

func TestBoardListall(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()
Expand Down Expand Up @@ -405,7 +381,7 @@ func TestBoardSearch(t *testing.T) {
// Verifies no board has FQBN set since no platform is installed
requirejson.Query(t, stdout, "[ .[] | select(.fqbn) ] | length", "0")
requirejson.Contains(t, stdout, `[
{"name": "Arduino Uno"},
{"name": "Arduino UNO"},
{"name": "Arduino Yún"},
{"name": "Arduino Zero"},
{"name": "Arduino Nano 33 BLE"},
Expand Down