-
-
Notifications
You must be signed in to change notification settings - Fork 403
[skip-changelog] Use golangci-lint #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a56857
to
6e82de9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2338 +/- ##
==========================================
+ Coverage 63.06% 63.20% +0.14%
==========================================
Files 201 201
Lines 19259 19285 +26
==========================================
+ Hits 12146 12190 +44
+ Misses 6059 6038 -21
- Partials 1054 1057 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of value in this tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we update the template repo too?
|
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Use
golangci-lint
instead of the deprecatedgolint
What is the current behavior?
We're using the deprecated
golint
to lint filesWhat is the new behavior?
Use the new
golangci-lint
Does this PR introduce a breaking change, and is titled accordingly?
Other information
I've picked the most valuable linters.
The following has been disabled as some of them contain many opinionated rules and are not to be considered a drop-in replacement of golint.
If this PR is accepted we have to update also the PR that contains all our workflows