-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added more debug
options
#2356
Conversation
e5685ae
to
9bf1523
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
+ Coverage 62.79% 62.98% +0.18%
==========================================
Files 203 203
Lines 19143 19243 +100
==========================================
+ Hits 12021 12120 +99
+ Misses 6068 6066 -2
- Partials 1054 1057 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
As described in arduino/arduino-cli#2356
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
There are 3 changes in the way debug configuration is build:
debug.server.openocd.scripts
is now an array, so multiple scripts may be provideddebug.server.openocd.script
(singular) is still supported but deprecated.svd_file
has been addeddebug.cortex-debug.custom.*
configuration keyslaunch.json
generated by the Arduino IDE. The array-style keys (ending with a numeric indexsomething.0=...
are automatically converted into JSON arrays. For example the configuration above will produce the following:What is the current behavior?
The added parameters are ignored.
What is the new behavior?
The added parameters are supported.
Does this PR introduce a breaking change, and is titled accordingly?
Only in the gRPC API.
Other information