Enable creating new sketches from a template directory #2359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Implements feature request in #2239, although instead of implementing a single "blueprint" file, allows for an entire template directory.
What is the current behavior?
Running
arduino-cli sketch new MySketch
will create aMySketch/MySketch.ino
file.What is the new behavior?
If
directories.template
is not set, the behavior is the same as before.If it is set, running
arduino-cli sketch new MySketch
will copy thedirectories.template
directory to create theMySketch
directory.Does this PR introduce a breaking change, and is titled accordingly?
This isn't a breaking change.
Other Information
Tests/docs haven't been written. Putting this up as a draft to get initial feedback before putting in more effort. One question how to handle setting
sketchMainFilePath
. Should we rename some file in the template directory toMySketch.ino
? Or just pick a .ino from the directory (ideally there's only one) and return that from the RPC call?