-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] cli: format json always start with a json object #2407
[breaking] cli: format json always start with a json object #2407
Conversation
f4aeca4
to
88f7058
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2407 +/- ##
==========================================
- Coverage 67.23% 67.16% -0.07%
==========================================
Files 210 210
Lines 20519 20523 +4
==========================================
- Hits 13796 13785 -11
- Misses 5589 5600 +11
- Partials 1134 1138 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
d55f197
to
2261009
Compare
99b4798
to
0e1f3f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
We're wrapping in json object all the results that previously were emitting directly an array
What is the current behavior?
Currently, some commands when printing with json, are starting with an array instead of an object
What is the new behavior?
We uniformed every command to always output a json Object.
Does this PR introduce a breaking change, and is titled accordingly?
Other information