[breaking] Remove gRPC settings service
#2411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Removes the gRPC
settingsservice, and migrates the RPC calls to thecommandservice.The service
cc.arduino.cli.settings.v1no longer exists and all existing RPC calls have been moved to thecc.arduino.cli.commands.v1service adding aSettingsprefix to the names of all messages. The existing RPC calls:rpc GetAll(GetAllRequest) returns (GetAllResponse)rpc Merge(MergeRequest) returns (MergeResponse)rpc GetValue(GetValueRequest) returns (GetValueResponse)rpc SetValue(SetValueRequest) returns (SetValueResponse)rpc Write(WriteRequest) returns (WriteResponse)rpc Delete(DeleteRequest) returns (DeleteResponse)are now renamed to:
rpc SettingsGetAll(SettingsGetAllRequest) returns (SettingsGetAllResponse)rpc SettingsMerge(SettingsMergeRequest) returns (SettingsMergeResponse)rpc SettingsGetValue(SettingsGetValueRequest) returns (SettingsGetValueResponse)rpc SettingsSetValue(SettingsSetValueRequest) returns (SettingsSetValueResponse)rpc SettingsWrite(SettingsWriteRequest) returns (SettingsWriteResponse)rpc SettingsDelete(SettingsDeleteRequest) returns (SettingsDeleteResponse)What is the current behavior?
No change
What is the new behavior?
No change
Does this PR introduce a breaking change, and is titled accordingly?
Yes.
Other information