Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion support to --profile #2426

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini self-assigned this Nov 14, 2023
@alessio-perugini alessio-perugini added the type: enhancement Proposed improvement label Nov 14, 2023
@alessio-perugini alessio-perugini added this to the Arduino CLI v0.36.0 milestone Nov 14, 2023
@alessio-perugini alessio-perugini force-pushed the add-completion-support-in-profiles branch 2 times, most recently from 0d8ca10 to b497e0f Compare November 14, 2023 17:46
@alessio-perugini alessio-perugini marked this pull request as ready for review November 14, 2023 17:47
@alessio-perugini alessio-perugini requested review from cmaglie, MatteoPologruto and umbynos and removed request for cmaglie November 14, 2023 17:47
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6c86fa2) 67.27% compared to head (07f0144) 67.29%.

Files Patch % Lines
internal/cli/arguments/sketch.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
+ Coverage   67.27%   67.29%   +0.01%     
==========================================
  Files         210      210              
  Lines       20523    20544      +21     
==========================================
+ Hits        13807    13825      +18     
- Misses       5578     5580       +2     
- Partials     1138     1139       +1     
Flag Coverage Δ
unit 67.29% <86.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini merged commit b41f404 into master Nov 16, 2023
196 checks passed
@alessio-perugini alessio-perugini deleted the add-completion-support-in-profiles branch November 16, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants