[breaking] Allow setting extra paths for build-cache #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps to better understand next commits.
cmaglie
added
type: enhancement
cmaglie
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2612 +/- ##
==========================================
+ Coverage 70.26% 70.30% +0.03%
==========================================
Files 222 222
Lines 21262 21304 +42
==========================================
+ Hits 14940 14977 +37
- Misses 5147 5151 +4
- Partials 1175 1176 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
previously requested changes
May 24, 2024
cmaglie
force-pushed
the
core_cache_extra_paths
branch
from
832dc81
to
79d4f7f
Compare
Co-authored-by: Alessio Perugini <alessio@perugini.xyz>
cmaglie
force-pushed
the
core_cache_extra_paths
branch
from
79d4f7f
to
8797c63
Compare
cmaglie
force-pushed
the
core_cache_extra_paths
branch
from
555cf7c
to
94b1983
Compare
cmaglie
requested review from
alessio-perugini,
Xayton,
umbynos and
MatteoPologruto
Xayton
approved these changes
May 29, 2024
umbynos
approved these changes
May 29, 2024
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Allows to specify extra paths for build-cache to look for already build artifacts if they are not found in the default build-cache dir.
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Yes.
Other information
Fix #2611