Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression: setting 3rd party URL via ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS env var #2645

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 18, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes a regression of release 1.0.0: setting more than one URL via ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS was impossible.

What is the current behavior?

$ export ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS="https://espressif.github.io/arduino-esp32/package_esp32_index.json https://arduino.esp8266.com/stable/package_esp8266com_index.json"
$ arduino-cli config get board_manager.additional_urls
- https://espressif.github.io/arduino-esp32/package_esp32_index.json https://arduino.esp8266.com/stable/package_esp8266com_index.json

The configuration is incorrect because the two URLs are concatenated in a single string.

What is the new behavior?

$ export ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS="https://espressif.github.io/arduino-esp32/package_esp32_index.json https://arduino.esp8266.com/stable/package_esp8266com_index.json"
$ arduino-cli config get board_manager.additional_urls
- https://espressif.github.io/arduino-esp32/package_esp32_index.json
- https://arduino.esp8266.com/stable/package_esp8266com_index.json

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fix #2643

@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 18, 2024
@cmaglie cmaglie merged commit 7d00b5b into arduino:master Jun 18, 2024
97 checks passed
@cmaglie cmaglie deleted the fix_config_file_via_env branch June 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to configure multiple URLs via ARDUINO_BOARD_MANAGER_ADDITIONAL_URLS
2 participants