Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monitor init handling #2728

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Fix monitor init handling #2728

merged 4 commits into from
Oct 11, 2024

Commits on Oct 10, 2024

  1. Fixed linter warn

    @cmaglie
    cmaglie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fc688ae View commit details
    Browse the repository at this point in the history

  2. Added integration test

    @cmaglie
    cmaglie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9bb4618 View commit details
    Browse the repository at this point in the history

  3. Fixed monitor dead-locking package manager

    @cmaglie
    cmaglie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5768352 View commit details
    Browse the repository at this point in the history

  4. Fix integration test: Allow some time for the mocked-monitor process … 

    …to terminate

otherwise the test will fail on Windows when the cleanup function tries to remove the
executable:

Error Trace:	D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:46
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:56
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:56
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:62
                D:/a/arduino-cli/arduino-cli/internal/integrationtest/daemon/daemon_concurrency_test.go:127
Error:          Received unexpected error:
                remove C:\Users\runneradmin\AppData\Local\Temp\cli2489057723\A\packages\builtin\tools\serial-monitor\0.14.1\serial-monitor.exe: Access is denied.
Test:           TestInitAndMonitorConcurrency
    @cmaglie
    cmaglie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a812e1a View commit details
    Browse the repository at this point in the history