Improve error message when port or fqbn flags are not set #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
improve-error-msgs
branch
2 times, most recently
from
0a42661 to
d235a6b
Compare
|
Hi @federicobond thanks for the PR. The code doesn't compile, can you please go through this doc https://github.com/arduino/arduino-cli/blob/master/CONTRIBUTING.md, make sure tests pass on your computer and then push again? I'll review your code as soon as the tests pass, thanks! |
federicobond
force-pushed
the
improve-error-msgs
branch
from
d235a6b to
d697109
Compare
federicobond
force-pushed
the
improve-error-msgs
branch
from
d697109 to
f04ff74
Compare
|
Hi @masci, sorry about that, I was trying to get the integration tests to pass and I botched the latest code changes! I still have some problems with the test match because the error is written to stderr, which is not captured by |
|
@masci done! |
masci
approved these changes
Dec 20, 2019
|
|
||
| currDownloadDir string | ||
| currDataDir string | ||
| currSketchbookDir string | ||
| ) | ||
|
|
||
| type stdOutRedirect struct { | ||
| type outputRedirect struct { |
|
I just noticed that this does not play along well with the board FQBN configured via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset marks the fqbn and port CLI flags as required in the compile and upload commands. The error message is thus changed from the generic:
To the more directly actionable:
Which is followed by the CLI help text.