Skip to content

Added external programmer support #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 15, 2020
Merged

Added external programmer support #720

merged 14 commits into from
Jun 15, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 22, 2020 •
edited
Loading

This PR add support for

  • list supported programmers for a board:
$ ./arduino-cli upload --fqbn arduino:avr:uno --programmer list
ID                     Programmer Name                Platform         
avrispmkii             AVRISP mkII                    arduino:avr@1.8.2
jtag3                  Atmel JTAGICE3 (JTAG mode)     arduino:avr@1.8.2
jtag3isp               Atmel JTAGICE3 (ISP mode)      arduino:avr@1.8.2
arduinoisp             ArduinoISP                     arduino:avr@1.8.2
usbGemma               Arduino Gemma                  arduino:avr@1.8.2
avrisp                 AVR ISP                        arduino:avr@1.8.2
parallel               Parallel Programmer            arduino:avr@1.8.2
buspirate              BusPirate as ISP               arduino:avr@1.8.2
arduinoasispatmega32u4 Arduino as ISP (ATmega32U4)    arduino:avr@1.8.2
usbasp                 USBasp                         arduino:avr@1.8.2
atmel_ice              Atmel-ICE (AVR)                arduino:avr@1.8.2
usbtinyisp             USBtinyISP                     arduino:avr@1.8.2
arduinoisporg          ArduinoISP.org                 arduino:avr@1.8.2
stk500                 Atmel STK500 development board arduino:avr@1.8.2
arduinoasisp           Arduino as ISP                 arduino:avr@1.8.2

  • upload with external programmer using the command line:
    arduino-cli upload .... -P programmer-id

  • burn bootlader:
    arduino-cli upload --fqbn ... --burn-bootloader (changed as per @ubidefeo suggestion)
    arduino-cli burn-bootloader --fqbn ....

Another improvement of this PR is that it makes the --port parameter mandatory only when really needed in upload patterns.

Missing:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@ubidefeo
Copy link

I would advice to keep the --burn-bootloader as its own command, hence burn-bootloader as a command to arduino-cli

example:
arduino-cli burn-bootloader --fqbn arduino:samd:nano_33_iot -p atmel_ice -v

upload, on the other hand, should be related to "uploading" or "programming" a firmware generated by the Arduino workflow

@cmaglie
Copy link
Member Author

cmaglie commented May 22, 2020

I would advice to keep the --burn-bootloader as its own command, hence burn-bootloader as a command to arduino-cli

Agreed, I'll fix this out.

@cmaglie cmaglie mentioned this pull request May 28, 2020
Closed
@cmaglie cmaglie linked an issue May 28, 2020 that may be closed by this pull request
External Programmer Support #27
Closed
cmaglie added 14 commits June 12, 2020 18:10
@cmaglie cmaglie added this to the 0.11.0 milestone Jun 12, 2020
@cmaglie cmaglie self-assigned this Jun 12, 2020
@cmaglie cmaglie requested review from rsora and ubidefeo June 12, 2020 16:15
rsora
rsora approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@cmaglie cmaglie merged commit 5373961 into arduino:master Jun 15, 2020
@cmaglie cmaglie deleted the ext-programmer branch June 15, 2020 14:55
umbynos pushed a commit that referenced this pull request Jun 17, 2020
@cmaglie @umbynos
Added external programmer support (#720)
ec44ad1 
* Added scaffolding for external programmer support

* Added programmers extraction in arduino/cores module

* Implemented programmers list command

* Print upload command line in verbose mode

* Added programmer option to compile command

* External programmer implementation

* Factored function runTool in upload

This will turn out useful for burn-bootloader that requires to run
two actions in a row ("erase" and "bootloader").

* Implemented burn-bootloader

* Increased tracing log

* Test fix

* Added BurnBootloder action

* Make the upload port parameter mandatory only when really needed

* Fixed nil pointer exception when burning-bootloader

* Added sanity check on upload parameters
@per1234 per1234 mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

External Programmer Support
3 participants
@cmaglie @ubidefeo @rsora