-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce the --input-file
flag for the upload
command
#777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some inline requests.
The business logic is OK.
9b3c87d
to
e10d0ff
Compare
25aab3a
to
c8b36e5
Compare
There is no point in overriding the sketch name if the user explicitly give it via command line.
fixes EquivalentTo when used with abs paths
c8b36e5
to
f2c4839
Compare
Ok, this one looked easy at a first glance but ended up being very complicated.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto-approving my changes :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested both with programmer and bootloader
worked as expected
Please check if the PR fulfills these requirements
This PR reintroduces the
-i
--input-file
flag for theupload
command, allowing to upload a single binary, according to the core recipeYou cannot specify a single binary file for the upload
This command allows the user to upload a specific pre-built binary
Reintroduces the flag that was deprecated in the last release (0.11.0)
Please note that the sketch binary extension (
.bin
in my example above) passed as the--input-file
value will be ignored, because the file extension for the binary files is explicity set at the core recipe level for each board.See for example here for the arduino:samd:mkrwifi1010 board upload recipe, that the
.bin
file is set explicitly:See how to contribute