Add device network configuration #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabik111
force-pushed
the
add-config-device
branch
from
9e01568 to
e055463
Compare
mirkokurt
reviewed
Jun 17, 2025
| } | ||
|
|
||
| if res != nil { | ||
| if res.Type() == cborcoders.WiFiNetworksType { |
There was a problem hiding this comment.
I'm confused by this check. Why we only check for WiFi network type?
There was a problem hiding this comment.
Because in this step the program is waiting for the list of wifi networks from the board. According to the protocol this step is mandatory.
For boards not supporting the WiFi an empty list must be sent by the board anyway.
There was a problem hiding this comment.
Ok. Please add a comment on the code to explain this
mirkokurt
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the release of the NetworkConfigurator library it's possible to store the network configuration of the device locally on it.
A client is needed for enabling the users to use this new feature.
Change description
configuresub command ofdevicemenù for network configurationcreatecommand for provisioningAdditional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.