Skip to content

[ATL-1253] replace reset implementation with the cli one, should be more robust #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2021
Merged

[ATL-1253] replace reset implementation with the cli one, should be more robust #633

merged 4 commits into from
Apr 23, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Apr 15, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Bug fix

  • What is the current behavior?
  • What is the new behavior?

The implementation used for resetting and uploading has been replaced with the cli one which should be more robust

  • Does this PR introduce a breaking change?

no AFAIK

  • Other information:

@umbynos umbynos self-assigned this Apr 16, 2021
@umbynos umbynos requested review from ubidefeo and a team and removed request for ubidefeo April 16, 2021 07:27
@umbynos umbynos changed the title replace reset implementation with the cli one, should be more robust [ATL-1253] replace reset implementation with the cli one, should be more robust Apr 21, 2021
rsora
rsora approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@umbynos umbynos merged commit 76ab40f into main Apr 23, 2021
@umbynos umbynos deleted the umbynos/device_setup_hardening branch April 23, 2021 09:20
umbynos added a commit that referenced this pull request Apr 23, 2021
@umbynos
[ATL-1253] replace reset implementation with the cli one, should be m…
f4d6577 
…ore robust (#633)

* replace reset implementation with the cli one, should be more robust

* use serialutils.go from the cli with the latest fixes

* fix getting started failing if the board is in bootloader mode

* alligned serialutils.go to the arduino-cli master version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@rsora rsora rsora approved these changes

Assignees

@umbynos umbynos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @silvanocerza @rsora