Skip to content

fix multi-line strings not being parsed correctly in config.ini #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2021
Merged

fix multi-line strings not being parsed correctly in config.ini #651

merged 2 commits into from
Jul 14, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 14, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

bugfix

  • What is the current behavior?

options in the config.ini were not initially designed to be on multiple lines.
It was impossible to add a PEM signing key in the config before.

  • What is the new behavior?

Explained above

  • Does this PR introduce a breaking change?

nop

  • Other information:

@umbynos umbynos added type: bug type: enhancement Proposed improvement labels Jul 14, 2021
@umbynos umbynos requested a review from a team July 14, 2021 14:19
@umbynos umbynos self-assigned this Jul 14, 2021
@umbynos umbynos merged commit 44614b3 into main Jul 14, 2021
@umbynos umbynos deleted the umbynos/pem_signature_newline branch July 14, 2021 15:59
umbynos added a commit that referenced this pull request Jul 15, 2021
@umbynos
fix multi-line strings not being parsed correctly in config.ini (#651)
d759c46 
* fix multi-line strings not being parsed correctly in `config.ini`

* add tests
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees

@umbynos umbynos

Labels
type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @silvanocerza @rsora