-
-
Notifications
You must be signed in to change notification settings - Fork 151
Bump GOA to V3 and generate #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2023
alessio-perugini
requested changes
Aug 28, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
- Coverage 10.96% 10.85% -0.12%
==========================================
Files 55 52 -3
Lines 4066 4036 -30
==========================================
- Hits 446 438 -8
+ Misses 3565 3543 -22
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Aug 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Bump GOA
GOA was inconsistently being used @ V1.0.1 in the
go.mod
file. While GOA 2.0.0-WIP was used for the generation. For maintenance reasons, we decided to bump it to v3 and generate the code again. This requires bumping also the GO version used (see #814).GOA is @ v3
It should not
Has to be rebases on main after #814 is merged ☑️