-
-
Notifications
You must be signed in to change notification settings - Fork 151
[breaking] Remove indexes v2 endpoint #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ebc0e2
to
55e50a3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 18.37% 19.09% +0.71%
==========================================
Files 53 46 -7
Lines 4120 3635 -485
==========================================
- Hits 757 694 -63
+ Misses 3257 2850 -407
+ Partials 106 91 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b22e469
to
53afd39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested on Linux and it works flawlessly. 🚀
Do you mind testing it on Windows? (Just to be sure that the hideFile
function still behaves correctly.)
Great job! Slowly making the agent great again! 😎
8cf8573
to
4f358e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nit: remove redundant getters methods from the tools struct
252a80f
to
3f05681
Compare
Just rebased to include changes from #836 |
run `goa gen github.com/arduino/arduino-create-agent/design`
the `.arduino-create` dir is now created by the `index.Init()` func
…ault package_index.json only and fix/adapt tests
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>
3f05681
to
5f0a64c
Compare
Please check if the PR fulfills these requirements
before creating one)
removal of indexes endpoint ("/v2/pkgs/indexes")
The indexes endpoint is not used and is a security risk, we are going to remove it
Index endpoint is not there anymore.
I took the opportunity to refactor a bit how the "package_staging_index.json" is treated. Now it's handled in the
index
package and is used by both the old implementation and the new GOA one.Yes, but the endpoint should not be used