Skip to content

agent-version.json is pushed on downloads bucket now, and minor enhancements #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 2, 2024
Merged

agent-version.json is pushed on downloads bucket now, and minor enhancements #896

merged 5 commits into from
Feb 2, 2024

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 1, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

CI enhancements

  • What is the current behavior?

The bucket we use to upload the agent-version.json file needed for the autoupdate will be dismissed.

  • What is the new behavior?

We are moving agent-version.json to the downloads servers.
I took the chance of performing some extra activities:

  • Bump installbuilder and gon
  • Drop old path where we push autoupdate files (not used anymore)
  • Does this PR introduce a breaking change?
  • Other information:

@umbynos umbynos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Feb 1, 2024
@umbynos umbynos self-assigned this Feb 1, 2024
alessio-perugini
alessio-perugini approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we will have a new frontend, we'll keep only the s3/bucket/agent-metadata right?

@umbynos
Copy link
Contributor Author

umbynos commented Feb 1, 2024

Exactly! I put the TODO for that reason

@umbynos umbynos changed the title Ci enhancements agent-version.json is pushed on downloads bucket now, and minor enhancements Feb 1, 2024
@umbynos
Copy link
Contributor Author

umbynos commented Feb 2, 2024

From Analytics, we know that /CreateBridge/ was last used in 2019. We can safely remove it.

@umbynos umbynos merged commit 6aa8183 into main Feb 2, 2024
@umbynos umbynos deleted the ci-enhancements branch February 2, 2024 10:46
This was referenced Feb 28, 2024
Merged
Closed
@pirropirro pirropirro mentioned this pull request Mar 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@Xayton Xayton Xayton approved these changes

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @alessio-perugini @Xayton