[skip-changelog] use OIDC to retrieve the credentials #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
requested review from
mschenone,
michelangelomo and
alessio-perugini
umbynos
commented
Feb 15, 2024
| - name: configure aws credentials | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} |
There was a problem hiding this comment.
This has been added to the environment production
umbynos
commented
Feb 15, 2024
Comment on lines
-13
to
-14
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} |
There was a problem hiding this comment.
- TODO remove these from the secrets
TODO remove AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY from secrets TODO add AWS_ROLE_TO_ASSUME to secrets
mschenone
approved these changes
Feb 22, 2024
alessio-perugini
approved these changes
Feb 26, 2024
umbynos
added a commit
that referenced
this pull request
Feb 27, 2024
2 tasks
umbynos
added a commit
that referenced
this pull request
Feb 27, 2024
* followup of #901, fix CI * fix permissions * fix environment * set permissions for the entire workflow * replace create-release deprecated action with the same one used in the cli * do not configure credentials when in pre-release (they are not used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
- [ ] Tests for the changes have been added (for bug fixes / features)Infra change
We currently use statically generated credentials to access to s3 buckets.
OpenID Connect allows workflows to exchange short-lived tokens directly from your cloud provider (see here)
Nop