Skip to content

add check on arduino-cli version used #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 1, 2022

The tool crashes if the wrong version of the cli is used (AKA version older or equal than 0.20.2) because this change is missing. This PR introduce a check that terminate the execution if an older version is used

@umbynos umbynos added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Feb 1, 2022
@umbynos umbynos requested a review from a team February 1, 2022 12:28
@umbynos umbynos self-assigned this Feb 1, 2022
Co-authored-by: per1234 <accounts@perglass.com>
@umbynos umbynos requested a review from per1234 February 1, 2022 14:33
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly for me.
Thanks Umberto!

@umbynos umbynos merged commit 55f9652 into main Feb 2, 2022
@umbynos umbynos deleted the umbynos/check_cli_version branch February 2, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants