Skip to content

The tool now generate a precompiled library that be linked later with the libs and the core #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 21, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jan 20, 2022

I used the precompiled libraries infrastructure in order to allow the origin sketch to be linked later against libraries and core.
Basically, cslt-tool now creates a precompiled lib structure and populates it with the required files.
See the README.md to learn how the tool behaves now. I tried to add as many comments as I could to let the posterity understand 👴🏽

@umbynos umbynos requested a review from a team January 20, 2022 17:17
@umbynos umbynos self-assigned this Jan 20, 2022
Copy link

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall but I'd make some small code adjustment and enhance a bit the documentation.
See the comments for more details.

@umbynos umbynos requested a review from silvanocerza January 21, 2022 12:01
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Arduino Library Specification recommends the additional files bundled with the library be placed in extras rather than extra.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Umberto!

Co-authored-by: per1234 <accounts@perglass.com>
@umbynos umbynos force-pushed the umbynos/use_precompiled_lib branch from 48182be to 1068440 Compare January 21, 2022 15:28
@umbynos umbynos merged commit 1ea44ce into main Jan 21, 2022
@umbynos umbynos deleted the umbynos/use_precompiled_lib branch January 21, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants