Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcoded Pin 13 to LED_BUILTIN #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ubidefeo
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The circuit description comment also needs to be dealt with:

- LED connected from digital pin 13 to ground through 220 ohm resistor

I'm not sure what the best approach is. The associated tutorial should be considered (of course it can be updated as needed).

Most of the examples are doing the same hardcoded pin 13 thing as this "PhysicalPixel" example was using. The only exceptions which are using LED_BUILTIN:

Those might serve as a useful model for how to proceed to take advantage of LED_BUILTIN in other examples and tutorials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants