Skip to content

Conversation

alessio-perugini
Copy link
Contributor

Fixed a regression in the winc flasher when trying to upload .pem files

@alessio-perugini alessio-perugini requested a review from umbynos July 17, 2023 15:44
@alessio-perugini alessio-perugini self-assigned this Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.63%. Comparing base (3b99ab6) to head (e4b472c).
⚠️ Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
flasher/winc.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #177      +/-   ##
========================================
- Coverage   6.66%   6.63%   -0.03%     
========================================
  Files         24      24              
  Lines       2146    2154       +8     
========================================
  Hits         143     143              
- Misses      1945    1953       +8     
  Partials      58      58              
Flag Coverage Δ
unit 6.63% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessio-perugini alessio-perugini changed the title Fix regression introduced after major refactoring Fix regression on winc pem certificates, introduced after major refactoring Jul 17, 2023
@alessio-perugini alessio-perugini changed the title Fix regression on winc pem certificates, introduced after major refactoring Fix regression on winc pem certificates Jul 17, 2023
@alessio-perugini alessio-perugini changed the title Fix regression on winc pem certificates Fix regression on winc when flashing pem certificates Jul 17, 2023
@umbynos
Copy link
Contributor

umbynos commented Jul 17, 2023

Indeed it works on a MKR1000

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 18, 2023
@alessio-perugini alessio-perugini merged commit bb28293 into main Jul 19, 2023
@alessio-perugini alessio-perugini deleted the fix-regression-on-winc-certificates branch July 19, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants