Fix wrong scrape of Root Certificates #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 12.10% 13.19% +1.09%
==========================================
Files 20 20
Lines 1165 1167 +2
==========================================
+ Hits 141 154 +13
+ Misses 971 957 -14
- Partials 53 56 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
force-pushed
the
fix-bug-on-certificates-scraper
branch
from
179bba4
to
7c13b50
Compare
alessio-perugini
added
the
type: imperfection
cmaglie
approved these changes
Aug 30, 2023
umbynos
reviewed
Aug 30, 2023
umbynos
reviewed
Aug 30, 2023
In the uno r4 we're using mbedtls which has a strange behaviour. And some root certificates won't work. Therfore the most simple solution is using all the possible ones, found during the handshake.
cmaglie
approved these changes
Aug 30, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #212 we can leverage the usage of ConnectionState.VerifiedChains and per docs:
So the last element of the VerifiedChains will be the actual RootCA!