Skip to content

"Dark (Arduino)" theme highlight color harms readability #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
reigate opened this issue Jun 9, 2022 · 2 comments · Fixed by #1125
Closed
3 tasks done

"Dark (Arduino)" theme highlight color harms readability #1028

reigate opened this issue Jun 9, 2022 · 2 comments · Fixed by #1125
Assignees
@91volt @francescospissu
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@reigate
Copy link

reigate commented Jun 9, 2022

Describe the problem

When Preferences>Theme>Dark(Arduino) is selected, highlight colour is bright yellow making any selected text almost impossible to read.

To reproduce

As above.

Expected behavior

Change the highlight colour.

Arduino IDE version

Version: 2.0.0-rc7 Date: 2022-06-09

Operating system

Windows

Operating system version

Windows 11 Pro

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@reigate reigate added the type: imperfection Perceived defect in any part of project label Jun 9, 2022
@per1234 per1234 added the topic: code Related to content of the project itself label Jun 9, 2022
@per1234 per1234 changed the title Theme "Dark (Arduino)" theme highlight color harms readability Jun 9, 2022
@kittaakos
Copy link
Contributor

Screen Shot 2022-06-13 at 15 16 56

For the record, this is with the new Dark (Arduino) theme, not the high contrast one.

@91volt
Copy link

91volt commented Jun 28, 2022

Updated in the json tokens

Dark mode highlight

Light mode highlight

@91volt 91volt closed this as completed Jun 28, 2022
@francescospissu francescospissu linked a pull request Jun 28, 2022 that will close this issue
Update themes #1125
Merged
@per1234 per1234 added conclusion: resolved Issue was resolved topic: theme Related to GUI theming labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@91volt 91volt

@francescospissu francescospissu

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update themes arduino/arduino-ide
5 participants
@kittaakos @per1234 @reigate @91volt @francescospissu