Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-functional Serial Monitor/Plotter #1161

Closed
3 tasks done
per1234 opened this issue Jul 10, 2022 · 0 comments · Fixed by #1162
Closed
3 tasks done

Non-functional Serial Monitor/Plotter #1161

per1234 opened this issue Jul 10, 2022 · 0 comments · Fixed by #1162
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Jul 10, 2022

Describe the problem

🐛 The Arduino IDE's Serial Monitor and Serial Plotter features are non-functional.

To reproduce

Equipment

  • Any Arduino board

Steps

  1. Connect an Arduino board to your computer.
  2. Select the board and port from the Arduino IDE menus.
  3. Upload a sketch that will demonstrate serial input and output capabilities are working:
    unsigned long previousMillis;
    void setup() {
      Serial.begin(9600);
    }
    void loop() {
      if (Serial.available() > 0) {
        while (Serial.available() > 0) {
          Serial.write(Serial.read());
          delay(10);
        }
      } else if (millis() - previousMillis >= 1000) {
        previousMillis = millis();
        Serial.println("hello");
      }
    }
  4. Open the "Serial Monitor" view.
    🐛 There is no baud rate menu.
    🐛 The expected output is not printed.
  5. Type some text in the "Message ..." field.
  6. Press Ctrl+Enter.
    🐛 The expected reaction to the message does not occur.
  7. Select Tools > Serial Plotter from the Arduino IDE menus.
    🐛 The Serial Plotter window does not open.

image

Expected behavior

Standard functionality from Serial Monitor and Serial Plotter.

image

Arduino IDE version

2.0.0-rc8-snapshot-7d96153

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

I bisected the bug to a36524e (does not occur when using the build for 1073c3f).


The following is printed to the logs the first time Serial Monitor or Serial Plotter is opened:

root INFO starting monitor
root ERROR Request startMonitor failed with error: Cannot read properties of undefined (reading 'client')
root ERROR Uncaught Exception:
root ERROR TypeError: Cannot read properties of undefined (reading 'client')
    at MonitorService.get coreClient [as coreClient] (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\core-client-provider.js:291:40)
    at MonitorService.portMonitorSettings (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\monitor-service.js:336:39)
    at new MonitorService (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\monitor-service.js:58:14)
    at MonitorManager.monitorServiceFactory (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\arduino-ide-backend-module.js:137:16)
    at MonitorManager.createMonitor (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\monitor-manager.js:241:30)
    at MonitorManager.startMonitor (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\monitor-manager.js:77:28)
    at MonitorManagerProxyImpl.startMonitor (C:\ide 2\tip\68-7d96153\resources\app\node_modules\arduino-ide-extension\lib\node\monitor-manager-proxy-impl.js:45:29)
    at JsonRpcProxyFactory.onRequest (C:\ide 2\tip\68-7d96153\resources\app\node_modules\@theia\core\lib\common\messaging\proxy-factory.js:127:49)
    at C:\ide 2\tip\68-7d96153\resources\app\node_modules\@theia\core\lib\common\messaging\proxy-factory.js:106:54
    at handleRequest (C:\ide 2\tip\68-7d96153\resources\app\node_modules\vscode-jsonrpc\lib\main.js:376:27)

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: serial monitor Related to the Serial Monitor labels Jul 10, 2022
kittaakos pushed a commit that referenced this issue Jul 10, 2022
Restored monitor service creation state before a36524e:
Pass core client provider into new instances as a field.

Closes #1161

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Jul 10, 2022
Restored monitor service creation state before a36524e:
Pass core client provider into new instances as a field.

Closes #1161

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Jul 11, 2022
Restored monitor service creation state before a36524e:
Pass core client provider into new instances as a field.

Closes #1161

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants