Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE shows correctly picks the theme based on the OS' theme, but it's incorrectly shown in the Settings #1223

Closed
3 tasks done
kittaakos opened this issue Jul 19, 2022 · 1 comment · Fixed by #1238
Closed
3 tasks done

IDE shows correctly picks the theme based on the OS' theme, but it's incorrectly shown in the Settings #1223

kittaakos opened this issue Jul 19, 2022 · 1 comment · Fixed by #1238
Assignees
@davegarthsimpson
Labels
conclusion: resolved Issue was resolved priority: high Resolution is a high priority topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jul 19, 2022 •
edited by per1234
Loading

Describe the problem

When I start the IDE for the first time and have a dark theme enabled, the IDE correctly comes up with the Dark (Arduino) theme, but the Light (Arduino) theme is shown in the Settings.

To reproduce

  • Mimic a first start, (delete ~/.arduinoIDE/settings.json and execute localStorage.clear() or equivalent)
  • Have an OS dark theme,
  • Start the IDE, (IDE starts with the dark theme ✅ )
  • Open the Settings, it shows the light theme 🐛

Screen Shot 2022-07-19 at 15 48 58

Expected behavior

The dark theme is selected.

Arduino IDE version

7680194

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 19, 2022
@kittaakos
Copy link
Contributor Author

kittaakos commented Jul 19, 2022 •
edited by per1234
Loading

Here is another problem, after the first start, open the preferences (it shows the light theme as described above), increase the UI scale, decrease it, press OK, IDE theme changes to light.

wrong_theme.mp4

@ubidefeo ubidefeo added the priority: high Resolution is a high priority label Jul 20, 2022
davegarthsimpson added a commit that referenced this issue Jul 27, 2022
@davegarthsimpson
#1223: use theme service on settings load (#1238)
f22be3c 
* use theme service on settings load

* use window.matchMedia in loadSettings

* typo fix

* Patched app config to dispatch on OS' theme.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Co-authored-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added conclusion: resolved Issue was resolved topic: theme Related to GUI theming labels Jul 31, 2022
@per1234 per1234 linked a pull request Aug 1, 2022 that will close this issue
#1223: use theme service on settings load #1238
Merged
4 tasks
@per1234 per1234 changed the title IDE2 shows correctly picks the theme based on the OS' theme, but it's incorrectly shown in the Settings IDE shows correctly picks the theme based on the OS' theme, but it's incorrectly shown in the Settings Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davegarthsimpson davegarthsimpson

Labels
conclusion: resolved Issue was resolved priority: high Resolution is a high priority topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1223: use theme service on settings load arduino/arduino-ide
5 participants
@kittaakos @ubidefeo @per1234 @davegarthsimpson @francescospissu