Skip to content

As a dev, I want to have better control over the themes and stylings of IDE2 #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
kittaakos opened this issue Nov 29, 2022 · 0 comments
Open
3 tasks done
Assignees
Labels
topic: infrastructure Related to project infrastructure topic: theme Related to GUI theming type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

Describe the request

IDE2 comes with two primary themes: Arduino Light and Arduino Dark. The themes define all colors for every UI element, including the coloring in the editors. These files are:

The IDE2 themes have flaws here and there; a few of them are the followings:

Devs cannot modify the theme JSON files manually because they're generated from a JSON file that is not part of this repository and is not under version control.

When somebody modifies the god JSON file, GH Actions automatically creates a PR with the derived theme JSON changes. See an example here or here. We can improve the following workflow.

  • Add documentation on what's happening and how to change the god JSON file to trigger the automatic PR.
  • When the theme update auto PR arrives, it does not contain the original author of the god JSON file. The auto-PR carries no information about why the change was made. (We could consider moving the god JSON file under version control)
  • Finally, as a dev, I would like to make tiny color changes and necessarily depend on others.

Describe the current behavior

n/a

Arduino IDE version

d6a4b0f

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@kittaakos kittaakos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure topic: theme Related to GUI theming labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure topic: theme Related to GUI theming type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants