Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Show Sketch folder" points to temp directory when opened via File > Sketchbook > Sketch_name #297

Closed
ubidefeo opened this issue Apr 2, 2021 · 1 comment
Closed

"Show Sketch folder" points to temp directory when opened via File > Sketchbook > Sketch_name #297

ubidefeo opened this issue Apr 2, 2021 · 1 comment
Assignees
@kittaakos @fstasi @silvanocerza
Labels
conclusion: resolved Issue was resolved priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@ubidefeo
Copy link

ubidefeo commented Apr 2, 2021 •
edited
Loading

Describe the bug
If I need to add files to my Sketch I need quickly find the folder and see my files,
but the Sketch > Show Sketch Folder opens the temporary directory, hence every change is lost.
i.e.: the Recent submenu does not update with the open Sketch

This only seems to happen when Sketch is open via File > Sketchbook.
The same file reports the correct absolute path if open via File > Open

To Reproduce
Steps to reproduce the behavior:

  1. Open a pre-existing Sketch (or save a new one)
  2. Click on Sketch > Show Sketch Folder
  3. Look at the containing tree
  4. You will see that you got directed to the temporary folder, not to the one inside the Sketchbook
  5. This seems to also prevent the **File > Open Recent ** not to have updated content even after a restart

Expected behavior
Pointing to the content of my Sketch inside the Sketchbook folder and having the File > Open Recent correctly show the file I last opened.

Screenshots
Screenshot 2021-04-02 at 10 07 37
Screenshot 2021-04-02 at 10 07 50
Screenshot 2021-04-02 at 10 08 04
Screenshot 2021-04-02 at 10 08 15
Screenshot 2021-04-02 at 10 08 28
Screenshot 2021-04-02 at 10 08 48

Desktop (please complete the following information):

  • OS: Mac OS 11.2.3 Big Sur
  • Version: 2.0.0-beta.4-nightly.20210402
@ubidefeo ubidefeo added type: bug priority: high Resolution is a high priority labels Apr 2, 2021
@ubidefeo ubidefeo changed the title "Show Sketch folder" points to temp directory and "Recent" not updating "Show Sketch folder" points to temp directory when opened via File > Sketchbook > Sketch_name Apr 6, 2021
@silvanocerza
Copy link
Contributor

I investigated a bit and turns out that this bug has been introduced by c64ac48 and PR #198.

kittaakos pushed a commit that referenced this issue Apr 7, 2021
GH-297: Fixed the open from Sketchbook handler.
a2e1c0a 
When running the handler for the `Sketchbook` menu, do not clone the
sketch.

Closes #297

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Apr 7, 2021
Merged
kittaakos pushed a commit that referenced this issue Apr 8, 2021
GH-297: Fixed the open from Sketchbook handler.
1860e35 
When running the handler for the `Sketchbook` menu, do not clone the
sketch.

Closes #297

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@per1234 per1234 added conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

@fstasi fstasi

@silvanocerza silvanocerza

Labels
conclusion: resolved Issue was resolved priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kittaakos @fstasi @ubidefeo @silvanocerza @per1234