Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose output preferences are not applied correctly #374

Closed
per1234 opened this issue May 16, 2021 · 1 comment · Fixed by #1237
Closed

Verbose output preferences are not applied correctly #374

per1234 opened this issue May 16, 2021 · 1 comment · Fixed by #1237
Assignees
@davegarthsimpson
Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented May 16, 2021 •
edited
Loading

Describe the bug

The File > Preferences > Show verbose output during preferences are meant to control the display of verbose output from the compilation or upload processes.

🐛Instead, they are controlling the display of all verbose output during the Verify or Upload actions.

Verbose compilation pref Verbose upload pref Action Compile output Upload output Correct
Unchecked Unchecked Verify non-verbose NA Yes
Unchecked Unchecked Upload non-verbose non-verbose Yes
Checked Unchecked Verify verbose NA Yes
Checked Unchecked Upload 🐛 non-verbose non-verbose 🐛 NO
Unchecked Checked Verify non-verbose NA Yes
Unchecked Checked Upload 🐛 verbose verbose 🐛 NO
Checked Checked Verify verbose NA Yes
Checked Checked Upload verbose verbose Yes

To Reproduce

  1. Select File > Preferences from the Arduino IDE's menus.
  2. Check the box next to Show verbose output during: [ ] compile
  3. Uncheck the box next to Show verbose output during: [ ] upload
  4. Click the OK button.
  5. Select Sketch > Upload from the Arduino IDE's menus.
    Expected behavior: verbose output from the compilation process is displayed. verbose output from the upload process is not displayed.
    Actual behavior: 🐛 no verbose output is displayed.
  6. Select File > Preferences from the Arduino IDE's menus.
  7. Uncheck the box next to Show verbose output during: [ ] compile
  8. Check the box next to Show verbose output during: [ ] upload
  9. Click the OK button.
  10. Select Sketch > Verify/Compile from the Arduino IDE's menus.
    Expected behavior: verbose output from the compilation process is not displayed. verbose output from the upload process is displayed.
    Actual behavior: 🐛 verbose output from both processes is displayed.

Expected behavior

Verbose output behavior to be aligned with the classic Arduino IDE.

Desktop

  • OS: Windows 10
  • Version: Version: 2.0.0-beta.6
    Date: 2021-05-12T10:22:48.736Z
    CLI Version: 0.18.2 alpha [7b5a22a4]

Additional context

Originally reported at: https://forum.arduino.cc/t/preferences-setting-mixup/862092
@per1234 per1234 added type: bug topic: code Related to content of the project itself labels May 16, 2021
@per1234 per1234 mentioned this issue May 16, 2021
Closed
@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@JonnyPhenomenon
Copy link

Yeah, wow. this one is all messed up.
I too identified this issue.

@ubidefeo ubidefeo added the criticality: medium Of moderate impact label Jun 22, 2022
@davegarthsimpson davegarthsimpson linked a pull request Jul 21, 2022 that will close this issue
#374: ensure compile verbose pref is included on upload #1237
Merged
4 tasks
@davegarthsimpson davegarthsimpson removed a link to a pull request Jul 21, 2022
#374: ensure compile verbose pref is included on upload #1237
Merged
4 tasks
@davegarthsimpson davegarthsimpson linked a pull request Jul 21, 2022 that will close this issue
#374: ensure compile verbose pref is included on upload #1237
Merged
4 tasks
davegarthsimpson added a commit that referenced this issue Jul 26, 2022
@davegarthsimpson
#374: ensure compile verbose pref is included on upload (#1237)
9373a0b 
* ensure compile verbose pref is included on upload

* better verbose typings

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Co-authored-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 mentioned this issue Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davegarthsimpson davegarthsimpson

Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#374: ensure compile verbose pref is included on upload arduino/arduino-ide
6 participants
@cmaglie @ubidefeo @per1234 @JonnyPhenomenon @rsora @davegarthsimpson