-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1009, #566: Use clang-format
as the default sketch formatter.
#1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ubidefeo
reviewed
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fstasi
approved these changes
Jun 6, 2022
This was referenced Jun 7, 2022
3 tasks
3 tasks
Closed
This was referenced Jun 8, 2022
Closed
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Jun 11, 2022
3 tasks
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use
clang-format
as the default sketch file formatter. It's faster and does not require a running LS.Change description
clangd
to14.0.0
,Other information
Closes #1009
Closes #566
For the reviewers:
$URI
[Range:$RANGE
] should be logged when theclang-format
-ter is used instead of the LS.(👆 The Format Document and Format Selection context menu items are available, although the LS is not running.)
sketch with spaces.ino
) or in the IDE path (/path/to/segment with spaces/arduino-ide
)..clang-format
file. The precedence is the following:~/.arduinoIDE/.clang-format
,directories#data/.clang-format
, orformat.mp4
Reviewer checklist