Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1015: Sketchbook handles more than two tree levels. #1144

Merged
merged 1 commit into from
Jul 5, 2022
Merged

#1015: Sketchbook handles more than two tree levels. #1144

merged 1 commit into from
Jul 5, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

IDE2 should show nested sketches.

Change description

Use a default false value for the explorer.compactFolders preference.
Ref: https://code.visualstudio.com/updates/v1_41#_compact-folders-in-explorer

Other information

In action:

compact_folders.mp4

Closes #1015.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Sketchbook handles more than two tree levels.
a6eff9c 
Use a default `false` value for the `explorer.compactFolders` preference

Closes #1015.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 4, 2022
francescospissu
francescospissu approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected 👍

@kittaakos kittaakos merged commit ea42dc5 into main Jul 5, 2022
@kittaakos kittaakos deleted the #1015 branch July 5, 2022 07:40
@per1234 per1234 mentioned this pull request Jul 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@francescospissu francescospissu francescospissu approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sketchbook view can't handle more than two tree levels
3 participants
@kittaakos @per1234 @francescospissu