Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase space between input and controls in dialogs #1159

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Increase space between input and controls in dialogs #1159

merged 3 commits into from
Jul 8, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

In dialogs with input the controls are not far enough from the input bar.

Screenshot 2022-07-08 131417

Change description

Bottom margin of the input increased.

Screenshot 2022-07-08 131243

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

kittaakos
kittaakos approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. Thank you!

@francescospissu francescospissu merged commit 7d96153 into main Jul 8, 2022
@francescospissu francescospissu deleted the new-file-dialog branch July 8, 2022 14:10
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@91volt 91volt Awaiting requested review from 91volt

Assignees
No one assigned
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francescospissu @kittaakos @per1234