Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary action button to the right of the notification box #1234

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Primary action button to the right of the notification box #1234

merged 1 commit into from
Jul 20, 2022

Conversation

francescospissu
Copy link
Contributor

@francescospissu francescospissu commented Jul 20, 2022 •
edited
Loading

Motivation

The primary action button should be to the right of the notification box.

Change description

Reverses the position of the buttons.

Before:
Screenshot 2022-07-20 152656

After:
Screenshot 2022-07-20 150825

Other information

Closes #1227.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

kittaakos
kittaakos approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@francescospissu francescospissu merged commit 5087ff0 into main Jul 20, 2022
@francescospissu francescospissu deleted the notification-primary-button branch July 20, 2022 14:49
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@fstasi fstasi Awaiting requested review from fstasi

@91volt 91volt Awaiting requested review from 91volt

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong "primary" button color?
3 participants
@francescospissu @kittaakos @per1234