Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming of nightly and snapshot builds #1326

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

AlbyIanna
Copy link
Contributor

Replace - with . to make auto-update work correctly

Motivation

Automatic updates are not working anymore with nightly builds.

Fixes #1318.

Change description

As suggested in #1318, using a . instead of a - to separate the "nightly" and "snapshot" build makes the semver comparison to work as expected.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

replace `-` with `.` to make auto-update work correctly
@AlbyIanna AlbyIanna requested a review from per1234 August 16, 2022 10:29
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 16, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it using the awesome arduino.ide.updateBaseUrl setting you added in #865 and it is working perfectly.

Thanks Alberto!

@AlbyIanna AlbyIanna merged commit 5be1f9d into main Aug 17, 2022
@AlbyIanna AlbyIanna deleted the nightly-naming branch August 17, 2022 15:13
AlbyIanna pushed a commit that referenced this pull request Sep 12, 2022
AlbyIanna pushed a commit that referenced this pull request Sep 12, 2022
@AlbyIanna AlbyIanna mentioned this pull request Sep 12, 2022
4 tasks
AlbyIanna pushed a commit that referenced this pull request Sep 12, 2022
per1234 pushed a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No automatic update to latest RC on nightly builds
2 participants