-
-
Notifications
You must be signed in to change notification settings - Fork 431
#177, #1188 Implemented filter and update all for libs/boards #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues jumping out code-wise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: now tracked at #1380
Since I think the benefits of the PR as it is greatly outweigh this UI glitch, I would not consider it a blocker for the merge, but thought I should report it regardless:
Describe the problem
End of list can't be reached using scrollbar when there are many search results
To reproduce
- Open the "Library Manager" view.
- Clear the "Filter your search..." field.
- Click and drag the scrollbar to the bottom.
🐛 The list was not scrolled anywhere near to the end. You can use the mouse wheel to scroll down to verify there are many other listings.
Expected behavior
Scrollbar can always be used to reach the end of the listings.
Arduino IDE version
2.0.0-rc9.2.snapshot-b7fc83f (tester build for c9cd17b)
Operating system
Windows
Operating system version
10
Additional context
I used the unfiltered list in the demo because it provides the most dramatic results, but it will also occur with filtered searches that provide a lot of results, such as motor
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: now tracked at #1381
Since I think the benefits of the PR as it is greatly outweigh this UI glitch, I would not consider it a blocker for the merge, but thought I should report it regardless:
Describe the problem
Scrollbar trails increasingly behind mouse pointer position while scrolling.
To reproduce
- Open the "Library Manager" view.
- Type
servo
in the "Filter your search..." field.
ⓘ This is only an arbitrary example of a common search query that might return in enough results to require scrolling. - Click and drag the scrollbar downwards.
🐛 The position of the scrollbar trails increasingly behind the mouse pointer position. If the Arduino IDE window is near the bottom of the screen, it may even become necessary to stop and "grab" the bar once more in order to move it all the way to the bottom position.
Expected behavior
Scrollbar position always matches mouse pointer position.
Arduino IDE version
2.0.0-rc9.2.snapshot-9f3d8d9 (tester build for 41fc14c)
Operating system
Windows, Linux
Operating system version
Windows 10, Ubuntu 20.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working nicely for me.
Thanks so much for your work on this important advancement Akos and Francesco!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected
LGTM
Closes arduino#177 Closes arduino#1188 Co-authored-by: Francesco Spissu <f.spissu@arduino.cc> Co-authored-by: Per Tillisch <p.tillisch@arduino.cc> Co-authored-by: Akos Kitta <a.kitta@arduino.cc> Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Motivation
Change description
Type
orTopic
andType
,Check for Updates
(IDE, libs, boards are done together. The preference is available from the Theia settings UI),Other information
Closes #177
Closes #1188
Reviewer checklist