-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace socks with socks5 in proxy protocol #1776
Conversation
The net/http package in arduino-cli supports socks5 as scheme rather than socks. Co-authored-by: per1234 <accounts@perglass.com>
I tested it on Windows. Both socks proxy and http proxy work
I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kittaakos Shall I replace the |
I am OK with both. If you do not change it to SOCKS5, there is nothing to discuss UI-wise. Hence the review will be faster. If you prefer to change the UI, we must discuss it with the designers first. It's up to you. |
I prefer to change the UI. Thanks for your reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK merging the PR as is, including the UI changes, as it fixes basic IDE2 functionality. We can open a follow-up and figure out internally what to do with the UI.
Do I need to revert the UI changes in this PR, then open a new PR for it? |
Follow-up: #1782 |
Motivation
Fixes #1769
The net/http package in arduino-cli supports
socks5
as scheme rather thansocks
. This PR replacessocks
withsocks5
in proxy protocol to make socks proxy work.Change description
socks
withsocks5
in proxy protocolSOCKS5
inPreferences
->Network
Other information
Reviewer checklist