Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing colon when parsing the protocol from URL #1778

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Remove trailing colon when parsing the protocol from URL #1778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3781023
Remove trailing colon when parsing the protocol from URL
wh201906 Dec 17, 2022
2a32cf2
Fix bug
wh201906 Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion arduino-ide-extension/src/common/protocol/config-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ export namespace Network {
try {
// Patter: PROTOCOL://USER:PASS@HOSTNAME:PORT/
const { protocol, hostname, password, username, port } = new URL(raw);
// protocol in URL object contains a trailing colon
const newProtocol = protocol.replace(/:$/, '');
return {
protocol,
protocol: newProtocol,
hostname,
password,
username,
Expand Down